Global Search - Radio Filters
What does this MR do?
Split off from a large MR: !46595 (merged)
Part 1 of 2 for #241691 (closed)
What we need to do
- Replace the Dropdown Filters with Radio Buttons Groups
- Move the filters to a new sidebar
Why this MR is needed
Doing both of the above steps in !46595 (merged) resulted in ~1,000 lines of code. For review-ability that was pretty daunting. I feel it would be easier to first review just the component swap here and then the pretty new UI in the next MR.
So what does this MR do?
This MR adds a Feature Flag :search_facets
that replaces the dropdown component with a radio button group. While still allowing the old dropdown to exists for now, until we move everything to the new sidebar in !46595 (merged)
I used the Feature Flag so we didn't need to spend a bunch of extra time creating a temporary "good looking" view. Instead we can just get the code in and then merge the actual desired change.
Screenshots (strongly suggested)
No Feature Flag | Feature Flag | |
---|---|---|
UI |
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines - [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team