Skip to content

Global Search - Radio Filters

Zack Cuddy requested to merge 241691_01-radio-filters into master

What does this MR do?

Split off from a large MR: !46595 (merged)
Part 1 of 2 for #241691 (closed)

What we need to do

  1. Replace the Dropdown Filters with Radio Buttons Groups
  2. Move the filters to a new sidebar

Why this MR is needed

Doing both of the above steps in !46595 (merged) resulted in ~1,000 lines of code. For review-ability that was pretty daunting. I feel it would be easier to first review just the component swap here and then the pretty new UI in the next MR.

So what does this MR do?

This MR adds a Feature Flag :search_facets that replaces the dropdown component with a radio button group. While still allowing the old dropdown to exists for now, until we move everything to the new sidebar in !46595 (merged)

I used the Feature Flag so we didn't need to spend a bunch of extra time creating a temporary "good looking" view. Instead we can just get the code in and then merge the actual desired change.

Screenshots (strongly suggested)

No Feature Flag Feature Flag
UI Screen_Shot_2020-11-03_at_11.14.05_AM Screen_Shot_2020-11-03_at_11.14.40_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Zack Cuddy

Merge request reports

Loading