Bump Node.js version to 12.18.4 in .nvmrc
What does this MR do?
This updates the NodeJS version in .nvmrc to match the one required by https://gitlab.com/gitlab-org/gitlab-development-kit/-/blob/master/.tool-versions
I ran into this error with gdk update because I have legacy_version_file = yes set in ~/.asdfrc, so it wanted to use the version 12.10.0 from gitlab/.nvmrc:
--------------------------------------------------------------------------------
Installing gitlab-org/gitlab Node.js packages
--------------------------------------------------------------------------------
No preset version installed for command node
Please install a version by running one of the following:
asdf install nodejs 12.10.0
or add one of the following versions in your config file at /home/toupeira/src/gitlab/gdk/.tool-versions
nodejs 12.18.4
nodejs 15.0.1
make: *** [Makefile:309: .gitlab-yarn] Error 126
❌️ ERROR: Failed to update.Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
- [-] Code review guidelines
- [-] Merge request performance guidelines
- [-] Style guides
- [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec - [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Markus Koller