Skip to content

Reduce object generation in HTMLGitlab

Robert May requested to merge formatter-memory-optimisation into master

What does this MR do?

This will reduce object generation when running the Rouge::Formatters::HTMLGitlab formatter by modifying the token value in place, rather than generating a new string. This should have a performance benefit, particularly when processing large files.

Related #232509 (closed)

Low-effort benchmark

irb(main):016:0> puts Benchmark.measure { 1_000_000.times { "abcdefghijklmnopqrstuvwxyz".split("").each { |l| l.chomp } } }
  3.872426   0.000002   3.872428 (  3.872567)
=> nil
irb(main):017:0> puts Benchmark.measure { 1_000_000.times { "abcdefghijklmnopqrstuvwxyz".split("").each { |l| l.chomp! || l } } }
  2.956353   0.000001   2.956354 (  2.956437)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Robert May

Merge request reports

Loading