Cut redundant validate! call from DAST service
What does this MR do?
removes manual call to Gitlab::UrlBlocker.validate!
which is already done when using Gitlab::HTTP.get
.
the bug is that the request would be made to the resolved ip address, which will result in a tls error e.g.
[72] pry(main)> uri, _ = Gitlab::UrlBlocker.validate!('https://twitter.github.io/')
=> [#<Addressable::URI:0x40c2c URI:https://185.199.108.153/>, "twitter.github.io"]
[73] pry(main)> Gitlab::HTTP.get(uri)
OpenSSL::SSL::SSLError: SSL_connect returned=1 errno=0 state=error: certificate verify failed (Hostname mismatch)
from /Users/philip/.rbenv/versions/2.7.2/lib/ruby/2.7.0/net/protocol.rb:44:in `connect_nonblock'
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entrybehind feature flag -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Philip Cunningham