Skip to content

Draft: Create independent class to manage sync triggers

Patrick Bair requested to merge 263135-add-column-during-partitioning into master

What does this MR do?

Related to #263135

As more migration helper methods are added for partitioning, the Gitlab::Database::PartioniningMigrationHelpers::TableManagementHelpers file is getting a bit large. Some of the functionality has potential use cases beyond partitioning, and so can be extracted out into isolated, reusable pieces.

Prior to adding additional migration helpers to this file, this MR separates out the logic to create a SyncTrigger into its own class. This can be used to add/remove a trigger to a table that will copy the writes into an duplicated table.

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Patrick Bair

Merge request reports

Loading