Skip to content

Handle empty project within Security Configuration

rossfuhrman requested to merge 262626-rescue-error into master

What does this MR do?

Addresses the error found in Sentry that occurs on the Security Configuration page when a project does not yet have a repository.

The call to the project history path was blowing up, and since we can't link to it, we return an empty string and the link does not get displayed.

This prevents the entire Security Configuration page from blowing up.

Screenshots (strongly suggested)

Here is the View History link that shows under normal circumstances: Screen_Shot_2020-11-10_at_12.23.09_PM

And here, that link is gone because there is no .gitlab-ci.yml to have any history. We will now not not be showing the link if there is no repository associated with a project or if there is no default branch set: Screen_Shot_2020-11-10_at_12.22.52_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #262626 (closed)

Edited by rossfuhrman

Merge request reports

Loading