Skip to content

Fix overly aggressive prevent call

Alex Kalderimis requested to merge ajk-group-member-policy into master

What does this MR do?

This fixes a bug where the rules that applied to the last owner of a group were too aggressive, preventing all actions.

This had non-sensical effects, such as preventing the owner of a group from reading their own group-member record, since even the policy :read_group is prevented.

This is fixed by limiting the list of prevented actions to only those we care about - specifically ones that could remove the last member and leave the group un-owned.

This ~bug was discovered during !40088 (merged), but these changes can be extracted a separate unit of work.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Alex Kalderimis

Merge request reports

Loading