Skip to content

Use GitLab UI styles on Integrations page

Tom Quirk requested to merge integrations-page-cleanup into master

What does this MR do?

  • Update integration name/link to use gl-font-weight-bold instead of strong tag
  • Updates on/off icon colors to be gl-text-{gray|green}-500
  • Adds title attribute to the status icon, which is set to the the same value as the existing aria-label
  • removes unnecessary mt-3 class for the table element

Screenshots (strongly suggested)

Before After
Screen_Shot_2020-11-12_at_2.54.21_pm Screen_Shot_2020-11-12_at_2.32.19_pm
Screen_Shot_2020-11-12_at_2.54.33_pm Screen_Shot_2020-11-12_at_2.32.27_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Tom Quirk

Merge request reports

Loading