Deprecate globalId for id in DastScannerProfile
requested to merge switch-back-to-id-instead-of-global-id-in-dast-scanner-profile-mutations-270084 into master
What does this MR do?
the merge request follows feedback in #270084 (closed) that indicates that id
may have been unnecessarily deprecated. according to @.luke this is because "we can freely swap a GraphQL::ID_TYPE
in a type with ::Types::GlobalIDType[::DastScannerProfile]
because the client receives both as a String
."
Related Issue(s)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Philip Cunningham