Skip to content

Fix tests relying on lazy-loaded images

Heinrich Lee Yu requested to merge 270459-fix-flaky-snippet-spec into master

What does this MR do?

Waits for the lazy loaded CSS class so that we don't read the src attribute before then.

This is the same thing we do in https://gitlab.com/gitlab-org/gitlab/blob/e053296665fdc34a3f7e4075cf5018a9dfb4b82a/spec/features/snippets/user_creates_snippet_spec.rb#L51

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #270459 (closed)

Edited by Heinrich Lee Yu

Merge request reports

Loading