Update feature_category of workers to code_review
What does this MR do?
There are some workers that are still tagged under source_code_management
.
They are more related to code_review
so this updates these workers to be tagged under code_review
.
This also includes some controllers and APIs that are tagged under code_review
but are now under source_code_management
(e.g. approval rules related).
Background
I grep'ed the gitlab
project for controllers/workers tagged under source_code_management
and this is the result:
app/controllers/admin/projects_controller.rb: feature_category :source_code_management, [:repository_check]
app/controllers/projects/blame_controller.rb: feature_category :source_code_management
app/controllers/projects/blob_controller.rb: feature_category :source_code_management
app/controllers/projects/branches_controller.rb: feature_category :source_code_management
app/controllers/projects/commit_controller.rb: feature_category :source_code_management
app/controllers/projects/commits_controller.rb: feature_category :source_code_management
app/controllers/projects/compare_controller.rb: feature_category :source_code_management
app/controllers/projects/find_file_controller.rb: feature_category :source_code_management
app/controllers/projects/forks_controller.rb: feature_category :source_code_management
app/controllers/projects/graphs_controller.rb: feature_category :source_code_management
app/controllers/projects/mirrors_controller.rb: feature_category :source_code_management
app/controllers/projects/network_controller.rb: feature_category :source_code_management
app/controllers/projects/protected_refs_controller.rb: feature_category :source_code_management
app/controllers/projects/raw_controller.rb: feature_category :source_code_management
app/controllers/projects/refs_controller.rb: feature_category :source_code_management
app/controllers/projects/repositories_controller.rb: feature_category :source_code_management
app/controllers/projects/settings/repository_controller.rb: feature_category :source_code_management, [:show, :cleanup]
app/controllers/projects/tags_controller.rb: feature_category :source_code_management, [:index, :show, :new, :destroy]
app/controllers/projects/tree_controller.rb: feature_category :source_code_management
app/controllers/projects_controller.rb: feature_category :source_code_management, [:remove_fork, :housekeeping, :refs]
app/controllers/repositories/git_http_client_controller.rb: feature_category :source_code_management
app/workers/admin_email_worker.rb: feature_category :source_code_management
app/workers/authorized_keys_worker.rb: feature_category :source_code_management
app/workers/authorized_project_update/periodic_recalculate_worker.rb: feature_category :source_code_management
app/workers/concerns/repository_check_queue.rb: feature_category :source_code_management
app/workers/create_commit_signature_worker.rb: feature_category :source_code_management
app/workers/create_note_diff_file_worker.rb: feature_category :source_code_management
app/workers/delete_diff_files_worker.rb: feature_category :source_code_management
app/workers/delete_merged_branches_worker.rb: feature_category :source_code_management
app/workers/detect_repository_languages_worker.rb: feature_category :source_code_management
app/workers/emails_on_push_worker.rb: feature_category :source_code_management
app/workers/gitlab_shell_worker.rb: feature_category :source_code_management
app/workers/hashed_storage/base_worker.rb: feature_category :source_code_management
app/workers/hashed_storage/migrator_worker.rb: feature_category :source_code_management
app/workers/hashed_storage/rollbacker_worker.rb: feature_category :source_code_management
app/workers/invalid_gpg_signature_update_worker.rb: feature_category :source_code_management
app/workers/merge_request_cleanup_refs_worker.rb: feature_category :source_code_management
app/workers/merge_request_mergeability_check_worker.rb: feature_category :source_code_management
app/workers/merge_worker.rb: feature_category :source_code_management
app/workers/migrate_external_diffs_worker.rb: feature_category :source_code_management
app/workers/namespaces/prune_aggregation_schedules_worker.rb: feature_category :source_code_management
app/workers/namespaces/root_statistics_worker.rb: feature_category :source_code_management
app/workers/namespaces/schedule_aggregation_worker.rb: feature_category :source_code_management
app/workers/new_merge_request_worker.rb: feature_category :source_code_management
app/workers/post_receive.rb: feature_category :source_code_management
app/workers/process_commit_worker.rb: feature_category :source_code_management
app/workers/project_cache_worker.rb: feature_category :source_code_management
app/workers/project_daily_statistics_worker.rb: feature_category :source_code_management
app/workers/project_destroy_worker.rb: feature_category :source_code_management
app/workers/rebase_worker.rb: feature_category :source_code_management
app/workers/remote_mirror_notification_worker.rb: feature_category :source_code_management
app/workers/repository_archive_cache_worker.rb: feature_category :source_code_management
app/workers/repository_check/dispatch_worker.rb: feature_category :source_code_management
app/workers/repository_cleanup_worker.rb: feature_category :source_code_management
app/workers/repository_fork_worker.rb: feature_category :source_code_management
app/workers/repository_remove_remote_worker.rb: feature_category :source_code_management
app/workers/repository_update_remote_mirror_worker.rb: feature_category :source_code_management
app/workers/requests_profiles_worker.rb: feature_category :source_code_management
app/workers/schedule_merge_request_cleanup_refs_worker.rb: feature_category :source_code_management
app/workers/schedule_migrate_external_diffs_worker.rb: feature_category :source_code_management
app/workers/stuck_merge_jobs_worker.rb: feature_category :source_code_management
app/workers/system_hook_push_worker.rb: feature_category :source_code_management
app/workers/trending_projects_worker.rb: feature_category :source_code_management
app/workers/update_external_pull_requests_worker.rb: feature_category :source_code_management
app/workers/update_merge_requests_worker.rb: feature_category :source_code_management
app/workers/update_project_statistics_worker.rb: feature_category :source_code_management
app/workers/x509_certificate_revoke_worker.rb: feature_category :source_code_management
app/workers/x509_issuer_crl_check_worker.rb: feature_category :source_code_management
ee/app/controllers/admin/push_rules_controller.rb: feature_category :source_code_management
ee/app/controllers/ee/admin/application_settings_controller.rb: feature_category :source_code_management, [:templates]
ee/app/controllers/groups/push_rules_controller.rb: feature_category :source_code_management
ee/app/controllers/projects/path_locks_controller.rb: feature_category :source_code_management
ee/app/controllers/projects/push_rules_controller.rb: feature_category :source_code_management
ee/app/workers/merge_request_reset_approvals_worker.rb: feature_category :source_code_management
ee/app/workers/repository_update_mirror_worker.rb: feature_category :source_code_management
ee/app/workers/update_all_mirrors_worker.rb: feature_category :source_code_management
ee/lib/api/group_push_rule.rb: feature_category :source_code_management
ee/lib/api/project_aliases.rb: feature_category :source_code_management
ee/lib/api/project_push_rule.rb: feature_category :source_code_management
lib/api/branches.rb: feature_category :source_code_management
lib/api/commits.rb: feature_category :source_code_management
lib/api/files.rb: feature_category :source_code_management
lib/api/internal/lfs.rb: feature_category :source_code_management
lib/api/project_snapshots.rb: feature_category :source_code_management
lib/api/project_statistics.rb: feature_category :source_code_management
lib/api/protected_branches.rb: feature_category :source_code_management
lib/api/protected_tags.rb: feature_category :source_code_management
lib/api/remote_mirrors.rb: feature_category :source_code_management
lib/api/repositories.rb: feature_category :source_code_management
lib/api/submodules.rb: feature_category :source_code_management
Based on that list, the only workers I found that needs to be updated are updated in this MR. Some controllers/workers were already tagged under code_review
feature category.
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team