Skip to content

Update Snowplow documentation

What does this MR do?

As @cwoolley-gitlab pointed out (!47589 (comment 449717556)) there is confusing detail about instrumenting frontend code with snowplow, that may cause events to not be collected

I was confused, because I was looking at and copying this example, which doesn't require wrapping in html_options.

But, that's only because of the behavior of link_to when it is passed a block - it accepts the second argument as html_options hash if passed a block.

The custom GitLab nav_link helper does not have this behavior, you have to explicitly pass the named html_options argument.

This MR aims to state difference between link_to and nav_link method, so the problem can be avoided

Related issues

Author's checklist (required)

Do not add the feature, frontend, backend, ~"bug", or database labels if you are only updating documentation. These labels will cause the MR to be added to code verification QA issues.

When applicable:

Review checklist

All reviewers can help ensure accuracy, clarity, completeness, and adherence to the Documentation Guidelines and Style Guide.

1. Primary Reviewer

  • Review by a code reviewer or other selected colleague to confirm accuracy, clarity, and completeness. This can be skipped for minor fixes without substantive content changes.

2. Technical Writer

  • Technical writer review. If not requested for this MR, must be scheduled post-merge. To request for this MR, assign the writer listed for the applicable DevOps stage.

For more information about labels, see Technical Writing workflows - Labels.

For suggestions that you are confident don't need to be reviewed, change them locally and push a commit directly to save others from unneeded reviews. For example:

  • Clear typos, like this is a typpo.
  • Minor issues, like single quotes instead of double quotes, Oxford commas, and periods.

For more information, see our documentation on Merging a merge request.

3. Maintainer

  1. Review by assigned maintainer, who can always request/require the above reviews. Maintainer's review can occur before or after a technical writer review.
  2. Ensure a release milestone is set.
  3. If there has not been a technical writer review, create an issue for one using the Doc Review template.
Edited by Jerome Z Ng

Merge request reports

Loading