Send full ref when triggering manual pipeline
What does this MR do?
When running a manual pipeline... If you send the short name of a ref and have a branch/tag named the same the pipeline creation will fail. This MR fixes that by sending the full ref name to ensure the pipeline is run on the correct ref and created properly.
This MR also makes a UI tweak by grouping branches and tags under sub-headers in the Run for dropdown. Just like we do for the repository ref dropdown.
Behind FF new_pipeline_form which is default enabled true.
Related to: #287818 (closed)
How to test
- Have a local runner and a project that is configured for CI
- Visit
http://localhost:3000/namespace/project/-/pipelines/new(example) - Run a pipeline for a branch and tag with the same name. Ensure they are created properly and full paths are correct for tags/branches.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [ - ] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [ - ] Database guides
- [ - ] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [ - ] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Payton Burdette