Skip to content

Allow failure for Secret Detection job

rossfuhrman requested to merge allow-failure-for-secret-detection into master

What does this MR do?

This makes Secret Detection behavior consistent with the other Secure analyzers.

Currently, a failure of the Secret Detection job will cause a pipeline to fail, but this is not the case for our other Secure jobs. With this change, a failure of the Secret Detection job will not cause a pipeline to fail.

Screenshots (strongly suggested)

Current behavior where the Secret Detection job caused the pipeline to fail. The other Secure jobs, gemnasium and license_scanning had the same error, but did not cause the pipeline to fail.

Screen_Shot_2020-11-19_at_9.39.21_AM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading