Skip to content

Send user email when their request to join an instance is denied

Serena Fang requested to merge 280596-user-admin-approval-reject-user into master

What does this MR do?

Add a "Reject request" button to user page when user is pending approval.

Clicking the button hard deletes the user and sends the user an email that their request to join an instance has been denied

Add a new admin route reject_admin_user DELETE /admin/users/:id/reject(.:format) admin/users#reject {:id=>/[a-zA-Z.\/0-9_\-]+/} `

Screenshots (strongly suggested)

Only render approve/reject buttons for a pending user-- removed the block user, delete user, and delete user and contribute buttons.

User page:

image

Pending approval tab dropdown:

(verified that rejecting a user through dropdown sends them an email and deletes them)

image

Rejection notice:

image

HTML email:

image

Plaintext email:

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #280596 (closed)

Edited by Serena Fang

Merge request reports

Loading