Skip to content

Avoid exception when validating diff_note support

What does this MR do?

Fixes unexpected exception when validating a DiffNote:

[dev](main)> DiffNote.new.valid?
NoMethodError: undefined method `has_complete_diff_refs?' for nil:NilClass
from /Users/kassioborges/src/gdk/gitlab/app/models/diff_note.rb:152:in `supported?'

Related to:

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kassio Borges

Merge request reports

Loading