Do not filter the relation name on import failures
What does this MR do?
Fields that end with key
are filtered out of the logs, for security
reasons. To avoid filtering the relation_key
on import failures use
relation_name
which is semantically equivalent and does not get
filtered.
Currently a log entry might look like:
{"severity":"ERROR", "time":"2020-11-19T17:02:12.627Z", "correlation_id":"6808792ce29553a48e4a545bf3e17d81",
"extra.source":"build_relation","extra.relation_key":"[FILTERED]","extra.relation_index":0,"extra.retry_count":0,
"extra.project_id":59,"exception.class":"StandardError","exception.message":"StandardError"}
After the fix it'd look like:
{"severity":"ERROR", "time":"2020-11-19T17:02:12.627Z", "correlation_id":"6808792ce29553a48e4a545bf3e17d81",
"extra.source":"build_relation","extra.relation_name":"notes","extra.relation_index":0,"extra.retry_count":0,
"extra.project_id":59,"exception.class":"StandardError","exception.message":"StandardError"}
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Kassio Borges