Skip to content

Add type=button to issue type selector close button to prevent premature submission

What does this MR do?

The close button on the "Issue Type" dropdown selector did not include type="button" which meant that, when pressed, it would attempt to submit the form, as per the default behavior for the button element. This could lead to premature submission of the create issue form, as reported here: #273580 (comment 438854497)

Screenshots (strongly suggested)

issue type selector screenshot

To verify:

  1. Open the new issue form
  2. Open the "Issue Type" dropdown
  3. Selecting a new issue type will probably close the dropdown
  4. Re-open the issue type dropdown and click the "X" close button at the top
  5. Ensure the form does not attempt to submit

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Related to #273580 (closed)

Edited by Jake Lear

Merge request reports

Loading