Handle blank default branch in security configuration
What does this MR do?
Related to https://sentry.gitlab.net/gitlab/gitlabcom/issues/1931129/?query=is%3Aunresolved%20security
We see on Sentry number of cases when someone tries to access Projects::Security::ConfigurationController#show
but it failed because default_branch
is nil
and gitlab_ci_history_path
cannot be generated. This fix addresses that problem.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. - [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Alan (Maciej) Paruszewski