Skip to content

Use v-html to build the breadcrumb

What does this MR do?

TLDR

This MR essentially reverts: !41207 (merged)

Since is now breaking the container registry breadcrumb by removing the > in between the breadcrumbs items.

This is a temporary workaround till: gitlab-ui!1869 (merged) is merged and released in gitlab, at that point we can go on on the path of: !48288 (merged)

Explaination

The container registry is an SPA page that uses vue-router, the container registry has the slowest API endpoints existing in the whole product (underlying issue with the registry implementation that is being slowly solved). The whole point of using the router is that so we can cache the info when navigating between the details and the list page ( to avoid an 18 seconds wait to load the list 😅 ).

To implement this we are forced to re-write the standard rails breadcrumb to use vue-router links.

@tnir Opened an MR to swap this approach to use gl-pagination the issue is that the component still do not accept a to prop and so it would not enable us to use vue-router

In this MR: !41207 (merged) we introduce v-safe-html which as we know does not like the SVG used for the breadcrumb divider, resulting in a broken breadcrumb.

I've re-introduced v-html (paired with manual call to sanitize function) in place of v-safe-html at least until we can unlock the proper implementation with gl-breadcrumb

Screenshots (strongly suggested)

Before After
Screenshot_2020-11-23_at_13.45.23 Screenshot_2020-11-23_at_13.45.06

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Nicolò Maria Mezzopera

Merge request reports

Loading