Add danger alert for misplaced changelogs with db changes
requested to merge 277398-follow-up-from-resolve-admin-license-timeout-on-large-instances into master
What does this MR do?
Adds a condition to report on misplaced changelog in these conditions:
- Migration exists in non
ee
- Changelog exists in
ee
The correct changelog placement in this scenario is inside FOSS
due to this reason
Screenshots (strongly suggested)
With new condition
- there are
ee
changes with anee
changelog, but a db migration exists.
With existing conditions(no change)
- there are
ee
changes, noee
changelog, and no db migrations.
- there are no
ee
changes, but anee
changelog exists.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #277398
Edited by Doug Stull