Skip to content

Draft: Clean up unused overriding flags in database

Shinya Maeda requested to merge add-delete-redundant-overriding-service into master

What does this MR do?

This MR introduces a maintaince worker to clean up unused overriding-flags from database.

The unused overridings can be fetched by (persisted_flags - YAML_definitions), because all of the feature flag references in code must have a corresponding YAML definitions.

This frees developers from the following manual step in the Feature Flag Rollout Issue. So one step ahead to automation.

Given this cleans up unused flag in database, it doesn't affect feature/application behavior at all. At any rates, the removed flags are logged/searchable in ElasticSearch/Kibana.

Related #276170

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Shinya Maeda

Merge request reports

Loading