Skip to content

Github Importer - import pull request merged by

Kassio Borges requested to merge kassio/add-github-merged-by-with-stage into master

What does this MR do?

related to: #30731 (closed)

The merged by field is not available on the list of pull requests, which is used to import the merge request. Therefore, for each merged pull request we need to do another request to Github to fetch this field.

Once fetched, if the user can be mapped to a GitLab user, it's added as to the MergeRequest::Metrics#merged_by. Otherwise, a note is added to the merge request with the text: 'Merged by "login"', where "login" is the Github login of the user who merged the pull request in Github.

Screenshots (strongly suggested)

  • When the user can be mapped to a GitLab user
Update_README_md___2____Merge_Requests___Administrator___foobar___GitLab
  • When the user cannot be mapped to a GitLab user
Update_README_md___3____Merge_Requests___Administrator___foobar___GitLab ## Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Kassio Borges

Merge request reports

Loading