Remove GlIcon aria-hidden code
What does this MR do?
This MR removes aria-hidden from <gl-icon>, since aria-hidden is added automatically by GlIcon when there isn't an aria-label.
The GlIcon change was made in gitlab-ui!1860 (merged) and was included in @gitlab/ui 23.11.1. GitLab is currently using 24.0.0.
Screenshots (strongly suggested)
The header_actions.vue component was checked to confirm that after removing aria-hidden we still see it in the rendered page due to GlIcon automatically adding it.
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team