Skip to content

Avoid unnecessary Sidekiq retries for Security::TokenRevocationService

Saikat Sarkar requested to merge reduce_redundent_api_call into master

What does this MR do?

This MR is related to this issue: https://gitlab.com/gitlab-org/gitlab/-/issues/288001. If there are no tokens to be revoked, we need to avoid Sidekiq retries for Security::TokenRevocationService. Because the Sidekiq job will eventually die after unsuccessful retries.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Saikat Sarkar

Merge request reports

Loading