Skip to content

Update settings_dropdown.vue to use text-sr-only attribute

Coung Ngo requested to merge cngo-update-settings_dropdown into master

What does this MR do?

This MR updates settings_dropdown.vue to use the text-sr-only attribute now that that GlDropdown can show SR only text.

Related discussion: !40409 (comment 401908745)

Screenshots (strongly suggested)

No visual changes. The following screenshot was taken after the code changes were made to confirm the dropdown button still has an accessible name.

Screenshot_2020-11-27_at_1.05.36_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading