Skip to content

[RUN-AS-IF-FOSS]Fix confirmation modal showing on project

What does this MR do?

The confirmation modal is supposed to be shown on the group and instance level integration forms when "Save changes" is clicked. A bug in the frontend code caused this to show on project level integrations when the option "Use default settings" was selected. This MR fixes this.

Steps to replicate

  • Setup a group (Group > Settings > Integrations - /groups/:namespace/-/settings/integrations/slack/edit) or instance (Admin > Settings > Integrations - /admin/application_settings/integrations/slack/edit) level integration.
  • Go to Project > Settings > Integrations (/:namespace/:project/-/services/slack/edit).
  • Select Use default settings in the dropdown.
  • Click on Save changes. Observe that the form is saving directly without showing a modal.

Screenshots (strongly suggested)

Slack

Confirmation_modal

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Jose Ivan Vargas

Merge request reports

Loading