Skip to content

Fix performance bar loading issue

Marc Shaw requested to merge fix_performance_bar into master

What does this MR do?

Related to: #287794 (closed)

Currently the performance bar isn’t working correctly, because we wait until the dom content event. This is triggered after requests have already been sent so we are missing these requests. But I don’t think we need to wait for this event, but not waiting for it could introduce a race condition with app/views/peek/_bar.html.haml, Since now if the DOM isn’t loaded by the time this script is run, we won’t have the #js-peek element

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Marc Shaw

Merge request reports

Loading