Skip to content

Add the default value for LDAP timout

Nourdin el Bacha requested to merge nelbacha-master-patch-34148 into master

What does this MR do?

It adds what the default value is for timeout. It looks like this is currently set to nil:

files/gitlab-cookbooks/gitlab/attributes/default.rb#306L

default['gitlab']['gitlab-rails']['ldap_sync_time'] = nil

Which translates to 0 via lib/gitlab/auth/ldap/config.rb#L149-151

def timeout
  options['timeout'].to_i
end

Closes #289834 (closed)

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Nourdin el Bacha

Merge request reports

Loading