Expose webhook data for GroupMember via its own data-builder class
What does this MR do?
Refactor, to be able to implement #260347 (closed)
This refactor helps to get all event data required for firing group member related webhooks from its own data-builder class, namely Gitlab::HookData::GroupMemberBuilder so that this information is not buried deep within the SystemHooksService class itself.
Use: To implement #260347 (closed), we need to access this same information for group-level webhooks and if this information is only available inside private methods of SystemHooksService class (as it exists today), we won't be able to leverage this existing code to build this feature.
Moving this out to a new class helps us re-use this code in both these places (ie, System hooks and group hooks)
No changelog added as this is only a refactor.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team