Require OTP for git+SSH
What does this MR do?
This MR adds capability to require OTP verification for git over SSH operations. OTP verification can be done via an internal API call. This endpoint is called from gitlab-shell with the 2fa_verify command (MR to gitlab-shell: gitlab-shell!440 (merged)).
Once the OTP is verified, a session is registered in Redis with 15 minutes TTL for the associated SSH key.
The feature is behind the two_factor_for_cli feature flag.
Demo: https://youtu.be/yl4qH1omfdY
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Imre Farkas