Resolve "Cannot remove namespace"
What does this MR do?
!48744 (merged) caused a regression. Here, the form submission and click handlers relied on $(this) from the jquery callback function. However, in !48744 (merged), these were refactored to arrow functions, which means the this references were not the this of the jquery callback function.
This MR:
- reverts these functions to regular JS functions (non-arrow)
- adds some extra guards and fallbacks for errors. This ensures the user will always get some error feedback.
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team