Truncate error messages for failed Group Import
What does this MR do?
Fixes https://sentry.gitlab.net/gitlab/gitlabcom/issues/2399934/?referrer=gitlab_plugin
During Group Import each error is captured in @shared.errors. If there are a lot of errors and all of them exceed 255 characters a new PG::CheckViolation is raised since we have a constraint on db level that last_error field in group_import_states table can't exceed 255 characters.
Because of this exception Group Import is never marked as failed and is 'stuck' in 'in progress' state. This change truncates the error message down to 255 to ensure it can't get stuck.
Mentions #290268 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team