Skip to content

Explicitly require public visibility of emails

Harsh Chouraria requested to merge hc-doc-imp-gh-email into master

What does this MR do?

The GitHub import performs a REST API call to fetch a user's email to associate their content to their GitLab account. The REST API of GitHub will show a null email address field if the primary email address is not marked to be publicly visible in the account's profile settings page.

Therefore the doc must (more) explicitly state the need for a publicly visible email address on the GitHub end prior to the import.

See also: https://docs.github.com/en/free-pro-team@latest/rest/reference/users#get-a-user

Screenshots (strongly suggested)

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading