Skip to content

Preconfigure fields for a default value stream

Ezekiel Kigbo requested to merge 267536-vsa-create-form-from-default into master

What does this MR do?

Updates the create value stream form to include default value stream stage information. The configuration for default stages is copied from the relevant backend configs, these are not editable and are only displayed to indicate how the value for each default stage is calculated.

Default stages can be:

  • re-ordered
  • hidden or restored

Feature flag

There are 2 feature flags required to see these changes:

  • value_stream_analytics_path_navigation: enables the path navigation UI
  • value_stream_analytics_extended_form: enables the additional form fields added here in the create value stream form

Caveats

To keep this MR moving, I've focused this only on the UI changes need for creating a value stream from defaults, some additional things we have left out of this MR:

  • Persisting changes: this will require updates to the create endpoint to take
  • Creating a value stream from scratch: these changes will come in a follow-up MR
  • Default stage configuration have been copied into the FE, eventually this should be passed from the BE

Screenshots (strongly suggested)

Default With field errors and hidden fields
Screen_Shot_2020-12-22_at_1.26.15_pm Screen_Shot_2020-12-23_at_7.40.14_pm

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team

Related to #267536 (closed)

Edited by Ezekiel Kigbo

Merge request reports

Loading