Skip to content

Textarea to input and adjust copy of expiration policy

What does this MR do?

This MR refactors the expiration policy settings textareas to input fields and adjusts the text of the toggle button and next run UI moment, following the feedback coming from this discussion: !48243 (comment 453482347)

The Plan

Description MR
Create a set of new components to implement the UI !47778 (merged)
Wire the new components and do UX and UI text reviews !48243 (merged)
Refactor textareas to input fields, adjust toggle and next-run text 👈 You are here!
Cleanup the shared folder and remove dead code TBD

Screenshots (strongly suggested)

Enabled State Disabled State Mobile
Screenshot_2020-12-03_at_11.36.09 Screenshot_2020-12-03_at_11.35.43 Screenshot_2020-12-03_at_11.38.15

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Related to #222885 (closed)

Edited by Nicolò Maria Mezzopera

Merge request reports

Loading