Override WORKHORSE_URL to check security mirror
What does this MR do?
With the vendoring of Workhorse, our CI checks if the content of
/workhorse
matches the workhorse repository tagged with
/GITLAB_WORKHORSE_VERSION
.
During a security release, this check may fail because the repository is hardcoded.
With this merge request, we override such value with the environment variable
GITLAB_WORKHORSE_URL
that is already in use in our RSpec suite to give access to our security mirror.
Closes: gitlab-workhorse#337 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Edited by Alessio Caiazza