Skip to content

Centralize how the Diffs app attaches/detaches from the event hub

Thomas Randolph requested to merge maintenance/clean-up-diffs-events into master

What does this MR do?

Moves general event hub subscriptions and unsubscriptions into specific handlers for that purpose.

Why

The number of events that the diffs app may subscribe to is theoretically unlimited.
Having each listener in the created/beforeDestroy methods is messy and could potentially obscure other important things happening in those lifecycle events.

It may be overkill to move the event hub interactions to another file entirely, but moving them to a separate method is a simple way to encapsulate potentially unbounded lines of code or modifications.

Notes

The app instrumentation also uses the event hub, but it needs to be bound beforeCreate, so it's kept separate.

Screenshots (strongly suggested)

N/A, just refactoring

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • [-] Label as security and @ mention @gitlab-com/gl-security/appsec
  • [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • [-] Security reports checked/validated by a reviewer from the AppSec team

Merge request reports

Loading