Allow alert incident title to include iid for HTTP integrations
What does this MR do?
Related issue: #255501 (closed)
This MR aligns incident-title functionality between the legacy generic AlertsService
and the new HttpIntegrations
.
Relevant behavior: When an alert is created without a title, a default title is used. If an incident is created from that alert, the incident title should include the issue IID so that the issues created this way are easily distinguishable.
Old version: Before changing the default issue title, checks that an AlertsService
is active for the project & the Alert Bot created the issue.
New version: Does not check for an active AlertsService
. We can do this because the AlertBot check is sufficient to determine that a user didn't choose this title. As we may have many HTTP integrations from which this alert might have come, checking for an active one is a cost we don't need.
Screenshots
Sample payload created via HTTP integration | New alert in alert list view | Incident created for alert |
---|---|---|
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team