Skip to content

Allow alert incident title to include iid for HTTP integrations

What does this MR do?

Related issue: #255501 (closed)

This MR aligns incident-title functionality between the legacy generic AlertsService and the new HttpIntegrations.

Relevant behavior: When an alert is created without a title, a default title is used. If an incident is created from that alert, the incident title should include the issue IID so that the issues created this way are easily distinguishable.

Old version: Before changing the default issue title, checks that an AlertsService is active for the project & the Alert Bot created the issue.

New version: Does not check for an active AlertsService. We can do this because the AlertBot check is sufficient to determine that a user didn't choose this title. As we may have many HTTP integrations from which this alert might have come, checking for an active one is a cost we don't need.

Screenshots

Sample payload created via HTTP integration New alert in alert list view Incident created for alert
Screen_Shot_2020-12-04_at_4.26.52_PM Screen_Shot_2020-12-04_at_4.27.01_PM Screen_Shot_2020-12-04_at_4.27.17_PM

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Sarah Yasonik

Merge request reports

Loading