Move integration inheritance override dropdown above grid layout
What does this MR do?
Final MR for #273269 (closed)
The primary purpose of this MR is to: on the settings form for an integration, move the "override" dropdown section outside (above) the grid layout so that it extends across the full width of the page. To do this, we need to:
- move grid-related styling from HAML to Vue
- In Vue, move the
override-dropdown
placement in the template
Additionally, this MR renames detailed_description
to help
for Confluence and GitHub integrations. All integrations are now consistent in their use of help
to display a notice to the user (see screenshots and !49325 (comment 487444700) for context)
Iteration | MR |
---|---|
1. Render help HTML in Vue | !49323 (merged) |
2. Move integration inheritance dropdown section above grid layout |
|
Screenshots (strongly suggested)
Screenshots demonstrate that the UI is consistent across all levels on integration.
Page | Before | After |
---|---|---|
Project-level integration | ||
Group-level integration | ||
Instance-level integration | ||
Service template |
Confluence and GitHub
Confluence and GitHub used to have detailed_descriptions
, but with these now renamed as help
, this content will appear in the left sidebar. This is consistent with all other integrations (e.g. Jira, above)
Page | Before | After |
---|---|---|
GitHub (project level) | ||
Confluence (project level) | ||
Confluence (group level) |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team