Skip to content

Approval rules code owners

Samantha Ming requested to merge approval-rules-code-owners into master
MR Changes
!46738 (merged) Part 1: Display approval rules
this MR Part 2: Display "Code Owner"

What does this MR do?

If the approval rules is of code_owner, it will display the text 'Code Owner' instead of what is provided in the rule_name.

This was raised in this MR > !46738 (comment 460295496)

Current This MR
image image

Testing Case

Here's the docs to setup [Code Owners](http://localhost:3000/help/user/project/code_owners`. This is what I'm using:

* @root
  1. Select a merge request that has some code changes
  2. In the sidebar reviewers dropdown, you will see Code Owner

image

  1. Click on "Edit", the reviewer dropdown will also have the same text

image

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Samantha Ming

Merge request reports

Loading