Capture subgroup creation failure during Group Import
What does this MR do?
This MR fixes a bug in Group Import via archive file which caused import to continue on a subgroup that failed creation validation. If non-persisted group is returned from Groups::CreateService https://gitlab.com/gitlab-org/gitlab/blob/master/lib/gitlab/import_export/group/tree_restorer.rb#L86-92 we still went ahead trying to import it's data into it, which leads to more errors (e.g. trying to create a label in a nonexistent group).
This MR checks to only continue with group restoration if that group creation succeeded, otherwise capture ImportFailure and skip this group. The same behaviour will be happening for any subgroups that have parent group missing.
Mentions #290291 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team