Add compare reports base service spec
Ref: #271077 (closed)
What does this MR do?
This MR extracts shared specs in the super class CompareReportsBaseService
.
Why are we doing this?
As brought up by @shinya.maeda:
We should just test this in the super class level
CompareReportsBaseService
. Currently, we're doing copy-paste this test in all of the subclasses, which harms the maintainability by racking up ~"technical debt" .
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines - [-] Merge request performance guidelines
-
Style guides - [-] Database guides
- [-] Separation of EE specific content
Availability and Testing
- [-] Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process.
- [-] Tested in all supported browsers
- [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Max Orefice