Refactor hasStartDate* methods from roadmap preset mixins
What does this MR do?
- Refactors the following methods to accept an argument(
timeframeItem) rather than depending on a computed prop(this.timeframeItem):
| method | location |
|---|---|
| hasStartDateForWeeks | weeks_preset_mixin.js |
| hasStartDateForMonths | months_preset_mixin.js |
| hasStartDateForQuarters | quarters_preset_mixin.js |
This change is a good standalone change but it will also make the migration of these mixins to a renderless component easier.
Related MRs
| merge request | what does it do |
|---|---|
| !48654 (merged) | Remove unused skeleton loader, css and fix mock data for roadmap specs |
| !49433 (merged) | Updates the existing mixin specs for roadmap |
| !49530 (merged) (current one) | Refactors hasStartDate* methods to accept an argument timeframeItem rather than using this.timeframeItem computed prop. |
| !48859 (closed) (WIP) | Use canvas to draw roadmap grid and create renderless scoped-component to replace mixins |
Screenshots (strongly suggested)
No visual change
Does this MR meet the acceptance criteria?
Conformity
Edited by euko