Speed up pull mirroring by asking Gitaly if tags have changed
What does this MR do?
Currently, pull mirroring will fetch the full list of tags for a repository twice - before and after the pull - and use the diff between them to work out which new tags have been added.
This seems unavoidable with the current output of git fetch, but we can skip doing the second call (and cache invalidation) if there have been no tag changes. This is the common, happy path, so should be worth implementing.
This MR is a rethink of !49140 (closed) , which streamed the git fetch output from gitaly into gitlab. That extra complexity turned out not to get us anything, so this one simplifies by doing that processing gitaly-side.
Gitaly MR is in gitaly!2901 (merged) . The first Gitaly release containing this code is v13.8.0.pre.rc-2
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #118683 (closed)