Skip to content

Update MR Approvals UI Text

Mike Jang requested to merge mjang-ux-MR-approvals-text into master

Update this section of the UI to meet the Pajamas style guidelines: Settings > General > Merge Request Approvals.

(note: if you don't see "Merge Request Approvals" in your deployment, this requires an Ultimate (I think) license.)

Closes technical-writing#311 (closed)

Guidance

Remember: With UI text, less is more. If you need to go into detail, link to the docs.

Closes technical-writing#311 (closed)

Review grammar and style

At a minimum, address these issues:

Do not change the text for settings themselves. If you do feel strongly that a setting name should be changed, open a follow-up issue and work with a PM to change it. When you change a setting, the related docs also need to change. These changes are outside the scope of this issue.

Screenshots (strongly suggested)

  • Before and after
Before After
MR-appovals-before merge-request-approvals-after

Note: The "Require approval from CODEOWNERS" setting was moved to [Protected Branches] line is outside the scope of the target modal, and is not covered in this MR.

Screenshots (strongly suggested)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Mike Jang

Merge request reports

Loading