Fix rendering of history items in members filter bar
What does this MR do?
Follow-up to #228675 (closed) and !48272 (merged)
app/assets/javascripts/vue_shared/components/filtered_search_bar/filtered_search_bar_root.vue history dropdown does not support GlFilteredSearchToken
with option titles. For example:
{
type: 'with_inherited_permissions',
icon: 'group',
title: s__('Members|Membership'),
token: GlFilteredSearchToken,
unique: true,
operators: [{ value: '=', description: 'is' }],
options: [
{ value: 'exclude', title: s__('Members|Direct') },
{ value: 'only', title: s__('Members|Inherited') },
],
},
This MR adds support for the title
attribute on options
Screenshots (strongly suggested)
Group members filter bar
Before | After |
---|---|
Project -> Incidents filter bar
Also uses filtered_search_bar_root.vue
. Screenshots should be the same
Before | After |
---|---|
Local testing
- Enable the
group_members_filtered_search
feature flagbin/rails console
Feature.enable(:group_members_filtered_search)
- Create a group
- Add members in Group -> "Members"
- Use the filter bar and sort dropdown
Does this MR meet the acceptance criteria?
Conformity
- [-] Changelog entry
- Not needed, behind the
group_members_filtered_search
feature flag
- Not needed, behind the
- [-] Documentation (if required)
-
Code review guidelines -
Merge request performance guidelines -
Style guides - [-] Database guides
-
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
- [-] Label as security and @ mention
@gitlab-com/gl-security/appsec
- [-] The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
- [-] Security reports checked/validated by a reviewer from the AppSec team
Edited by Peter Hegman