Skip to content

Set dast_site_validation_id on validation create

What does this MR do?

this merge request ensures that the relevant dast_site is associated with the dast_site_validation once it is created.

Why?

we were previously not performing this update, which was resulting in another model (dast_site_profile) returning 'none' as a result of the association being missing. this was exacerbated by some assumptions made in test factories, which were always creating transitory dependencies implicitly.

Related Issue(s)

Does this MR meet the acceptance criteria?

Conformity

Availability and Testing

Security

If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:

  • Label as security and @ mention @gitlab-com/gl-security/appsec
  • The MR includes necessary changes to maintain consistency between UI, API, email, or other methods
  • Security reports checked/validated by a reviewer from the AppSec team
Edited by Philip Cunningham

Merge request reports

Loading