Update Audit Events navigation and visibility
What does this MR do?
This MR attempts to achieve two things:
- Relocate
Audit Events
submenu inSettings
menu to be underSecurity & Compliance
menu (for bothProjects
andGroups
) - Adjust permission to view
Audit Events
toDeveloper
role and above
⚙ Implementation
- Rejig
projects_helper
,groups_helper
and related haml to relocateAudit Events
submenu - Incoporate
read_project_audit_events
andread_group_audit_events
permission to both controller and view - Add more test coverage
- Fix all QA tests related to menu relocations
📷 Screenshots (strongly suggested)
Menu relocation
Name | Before | After |
---|---|---|
Project | ||
Group |
Search page appearance by roles
Name | Before | After |
---|---|---|
Project Audit Events |
Maintainer and higher |
Developer |
Group Audit Events | Owner and higher |
Maintainer and Developer |
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry - [-] Documentation (if required) (!49930 (merged))
-
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers - [-] Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec
-
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team
Related to #257514 (closed)
Edited by Tan Le