Gitlab Importer - Skip some validations in Project/Group import
What does this MR do?
Some Project/Group imports are not importing all the relations due to some subrelations (nested relations) being invalid. To avoid that, and fix exceptions like #285107 (closed), every relation created will, from now on, will be validated.
Though, while working on enabling this validation, some tests failed, exposing that some validations are actually blocking some imports.
Validations to check if a major association exists, or follow some kind of requirements, like "DiffNote validating if the MergeRequest is associated", doesn't work in the import process because the relations are created in a nested way. Something like:
diff_note = DiffNote.create(diff_note_attributes)
mr = MergeRequest.create(mr_attributes, diff_notes: [diff_note])This commit skip these validations on the importing process, using the
validates :validation, unless: :importing? pattern.
Related to: #293705 (closed)
Screenshots (strongly suggested)
Does this MR meet the acceptance criteria?
Conformity
-
Changelog entry -
Documentation (if required) -
Code review guidelines -
Merge request performance guidelines -
Style guides -
Database guides -
Separation of EE specific content
Availability and Testing
-
Review and add/update tests for this feature/bug. Consider all test levels. See the Test Planning Process. -
Tested in all supported browsers -
Informed Infrastructure department of a default or new setting change, if applicable per definition of done
Security
If this MR contains changes to processing or storing of credentials or tokens, authorization and authentication methods and other items described in the security review guidelines:
-
Label as security and @ mention @gitlab-com/gl-security/appsec -
The MR includes necessary changes to maintain consistency between UI, API, email, or other methods -
Security reports checked/validated by a reviewer from the AppSec team